Skip to content

Conversation

@jl-wynen
Copy link
Member

@jl-wynen jl-wynen commented Jan 3, 2024

Fixes #11

@jl-wynen jl-wynen requested a review from SimonHeybrock January 3, 2024 10:55
graphviz
pythreejs
https://github.com/scipp/scipp/releases/download/nightly/scipp-nightly-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
https://github.com/scipp/scipp/releases/download/nightly/scipp-nightly-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. All I did is run tox -e deps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... in the wrong env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used python 3.10 to lock dependencies. I re did it with 3.9 now which reverted the change here.

@jl-wynen jl-wynen changed the base branch from more-warning-filters to main January 3, 2024 12:02
@jl-wynen jl-wynen enabled auto-merge January 3, 2024 16:03
@jl-wynen jl-wynen merged commit 9ecec83 into main Jan 4, 2024
@jl-wynen jl-wynen deleted the geant4-loader branch January 4, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy DREAM GEANT4 loader into essdiffraction

3 participants